Respond to rev2 #31
Merged
Respond to rev2 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temospena
changed the title
31 tasks
|
Looking at the error message in Actions I think it was because Added as a 'Suggests' with: in latest commit. |
|
Interesting error message: https://github.com/ITSLeeds/slopes/runs/2815009282#step:9:53 Maybe worth trying with |
Robinlovelace
approved these changes
Jun 21, 2021
vignettes/roadnetworkcycling.Rmd
Outdated
| # res(dem) #27m of resolution | ||
| network = iow_network_segments | ||
|
|
||
| raster::plot(dem) |
There was a problem hiding this comment.
Nice result @temospena, I didn't know this was where the hills were in IoW:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ropensci/software-review#420 (comment)
pass benchmark to a vignette and remove from README
Update argument names
@param r -> routes
in slopes.R and plot_slope.R and slope_get.R and README
@param e -> elevations (values)
in slopes.R and plot_slope.R
@param e -> dem (raster)
in slopes.R and README
lonlat-> defaults were revised and updateddo not export plot_dz from plot_slope.R